Streamlined and unified opacity methods#73
Open
victor-homyakov wants to merge 1 commit intoprototypejs:masterfrom
Open
Streamlined and unified opacity methods#73victor-homyakov wants to merge 1 commit intoprototypejs:masterfrom
victor-homyakov wants to merge 1 commit intoprototypejs:masterfrom
Conversation
Currently methods for getting/setting opacity have different workflow:
- in IE w/o opacity support `getStyle_IE` invokes `getOpacity_IE`
- in other browsers `getOpacity` invokes `getStyle` (doing unneeded operations like `normalizeStyleName('opacity')`)
Also `setOpacity_IE` and `getOpacity_IE` check `STANDARD_CSS_OPACITY_SUPPORTED` each time they are invoked (not good for animation performance).
Collaborator
|
Hey, can I ask a favor? I want to apply this, but before I do, I need to make absolutely sure that this works in:
If you can assure me that the tests pass in all three of the above (for #2, testing any one of IE 7, 8, or 9 works for me), then I'll merge this. I'm very cautious about this code because I last touched it to add support for IE 10, and it was painstaking surgery to arrive at something that worked everywhere. |
Contributor
Author
|
Contributor
Author
|
There is another opacity-related issue, now in Opera: https://prototype.lighthouseapp.com/projects/8886/tickets/1282-latest-prototypejs-from-github-repo-fails-in-opera - should I make another pull request or include in this one? |
Collaborator
|
I'd say make another one. I'll merge this one soon enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently methods for getting/setting opacity have different and inefficient workflow:
getStyle_IEinvokesgetOpacity_IE(but only after useless operations likenormalizeStyleName_IE())getOpacityinvokesgetStyle(doing useless operations likenormalizeStyleName('opacity'))Also
setOpacity_IEandgetOpacity_IEcheckSTANDARD_CSS_OPACITY_SUPPORTEDeach time they are invoked (not good for animation performance).